Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 17589014: Write a log list for uploaded WebRTC logs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some unit test changes. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 6673807f1b4a8ba24337e87802d4c40513f2125a..bffe16e08514ccac9c91979193f3f739280831a5 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -636,8 +636,10 @@ bool BrowserProcessImpl::created_local_state() const {
#if defined(ENABLE_WEBRTC)
WebRtcLogUploader* BrowserProcessImpl::webrtc_log_uploader() {
- if (!webrtc_log_uploader_.get())
- webrtc_log_uploader_.reset(new WebRtcLogUploader());
+ if (!webrtc_log_uploader_.get()) {
+ base::FilePath empty_path;
+ webrtc_log_uploader_.reset(new WebRtcLogUploader(empty_path));
jochen (gone - plz use gerrit) 2013/07/01 11:46:26 nit. Doesn't WebRtcLogUploader(base::FilePath()) w
tommi (sloooow) - chröme 2013/07/01 12:01:01 instead of requiring an empty path can we have two
Henrik Grunell 2013/07/01 13:26:22 As per the next comment, I've removed the argument
+ }
return webrtc_log_uploader_.get();
}
#endif
« no previous file with comments | « no previous file | chrome/browser/media/webrtc_log_uploader.h » ('j') | chrome/browser/media/webrtc_log_uploader.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698