Issue 17586004: Reverted the removal of suppressions in http://crrev.com/208214.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17586004: Reverted the removal of suppressions in http://crrev.com/208214. (Closed)

Created:
7 years, 6 months ago by Joao da Silva

Modified:
7 years, 6 months ago

Reviewers:
David Roche

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reverted the removal of suppressions in http://crrev.com/208214. The tests still have more leaks than those fixed in that revision. TBR=davidroche@chromium.org BUG=253434 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208231

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Joao da Silva

Committed patchset #1 manually as r208231 (presubmit successful).

7 years, 6 months ago (2013-06-24 17:41:48 UTC) #1

Joao da Silva

David, these tests are still leaking even after deleting the Fetchers, but I'm not sure ...

7 years, 6 months ago (2013-06-24 17:43:48 UTC) #2

David Roche

7 years, 6 months ago (2013-06-24 18:17:47 UTC) #3

Message was sent while issue was closed.

LGTM

I found the other leak, will send a CL out shortly.