Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 17585006: Remove HTMLDocument.width and height properties (Closed)

Created:
7 years, 6 months ago by esprehn
Modified:
7 years, 6 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove HTMLDocument.width and height properties No other rendering engine except WebKit supports these now, and they only support it apparently for content in WebView. Reference: https://developer.mozilla.org/en-US/docs/Web/API/document.height https://bugs.webkit.org/show_bug.cgi?id=72591 https://bugs.webkit.org/show_bug.cgi?id=80494 R=abarth@chromium.org,arv@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152987

Patch Set 1 #

Patch Set 2 : Fix device metrics test with Internals API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -35 lines) Patch
D LayoutTests/fast/dom/HTMLDocument/width-and-height.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/styles/device-metrics-fit-window.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/inspector/styles/device-metrics-fit-window-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-mac/inspector/styles/device-metrics-fit-window-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
esprehn
7 years, 6 months ago (2013-06-24 16:30:53 UTC) #1
arv (Not doing code reviews)
LGTM This is an old NN4 layer quirk. The way to get the width of ...
7 years, 6 months ago (2013-06-24 16:39:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/17585006/1
7 years, 6 months ago (2013-06-24 16:51:03 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=13801
7 years, 6 months ago (2013-06-24 17:57:49 UTC) #4
esprehn
On 2013/06/24 17:57:49, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 6 months ago (2013-06-24 18:30:23 UTC) #5
esprehn
I added internals.unscaledViewportRect() so the test can pass, this also makes the test better since ...
7 years, 6 months ago (2013-06-25 01:41:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/17585006/16001
7 years, 6 months ago (2013-06-25 01:41:50 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=10877
7 years, 6 months ago (2013-06-25 02:34:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/17585006/16001
7 years, 6 months ago (2013-06-25 04:47:33 UTC) #9
commit-bot: I haz the power
Change committed as 152987
7 years, 6 months ago (2013-06-25 05:17:01 UTC) #10
tkent
FYI. Bugs were filed when we removed them last year. https://code.google.com/p/chromium/issues/detail?id=114138 https://code.google.com/p/chromium/issues/detail?id=113528
7 years, 6 months ago (2013-06-25 05:25:43 UTC) #11
arv (Not doing code reviews)
7 years, 6 months ago (2013-06-25 14:42:26 UTC) #12
Message was sent while issue was closed.
On 2013/06/25 05:25:43, tkent wrote:
> FYI. Bugs were filed when we removed them last year.
> https://code.google.com/p/chromium/issues/detail?id=114138
> https://code.google.com/p/chromium/issues/detail?id=113528

Well, since then, Firefox have been shipping without it for a while. If there
are still sites out there that use this we should evangelize.

Powered by Google App Engine
This is Rietveld 408576698