Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 17583006: Removes the m17n input methods from the Chromium OS as the chromeos-keyboards extension will replac… (Closed)

Created:
7 years, 6 months ago by Shu Chen
Modified:
7 years, 5 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removes the m17n input methods from the Chromium OS as the chromeos-keyboards extension will replace them. BUG=240659 TEST=Verified locally. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208190

Patch Set 1 #

Patch Set 2 : Replace vi:VNI. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/ime/input_methods.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Seigo Nonaka
lgtm
7 years, 6 months ago (2013-06-24 08:21:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/17583006/1
7 years, 6 months ago (2013-06-24 08:44:15 UTC) #2
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 10:36:44 UTC) #3
Message was sent while issue was closed.
Change committed as 208190

Powered by Google App Engine
This is Rietveld 408576698