Issue 17582013: ui::Clipboard now uses base::win::MessageWindow to create a message-only window on Windows.

Issue 17582013: ui::Clipboard now uses base::win::MessageWindow to create a message-only window on Windows. (Closed)

Created:
7 years, 6 months ago by alexeypa (please no reviews)

Modified:
7 years, 5 months ago

Reviewers:
tony, dcheng

CC:
chromium-reviews, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui::Clipboard now uses base::win::MessageWindow to create a message-only window on Windows. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209098

Patch Set 4 : rebased #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -41 lines)			Patch
	M	ui/base/clipboard/clipboard.h	View		3 chunks	+7 lines, -4 lines	0 comments	Download
	M	ui/base/clipboard/clipboard_win.cc	View	1 2	8 chunks	+22 lines, -37 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dcheng

LGTM https://chromiumcodereview.appspot.com/17582013/diff/2001/ui/base/clipboard/clipboard_win.cc File ui/base/clipboard/clipboard_win.cc (right): https://chromiumcodereview.appspot.com/17582013/diff/2001/ui/base/clipboard/clipboard_win.cc#newcode102 ui/base/clipboard/clipboard_win.cc:102: LRESULT lresult = 0; Nit: Remove this, since ...

7 years, 5 months ago (2013-06-27 17:56:22 UTC) #3

alexeypa (please no reviews)

https://chromiumcodereview.appspot.com/17582013/diff/2001/ui/base/clipboard/clipboard_win.cc File ui/base/clipboard/clipboard_win.cc (right): https://chromiumcodereview.appspot.com/17582013/diff/2001/ui/base/clipboard/clipboard_win.cc#newcode102 ui/base/clipboard/clipboard_win.cc:102: LRESULT lresult = 0; On 2013/06/27 17:56:23, dcheng wrote: ...

7 years, 5 months ago (2013-06-27 17:58:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/17582013/9003

7 years, 5 months ago (2013-06-27 18:01:38 UTC) #5

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=144266

7 years, 5 months ago (2013-06-27 21:18:11 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/17582013/9003

7 years, 5 months ago (2013-06-28 01:56:36 UTC) #7

Message was sent while issue was closed.

Change committed as 209098

Expand Messages | Collapse Messages