Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1757593002: media: Update PipelineIntegrationTestBase to support MemoryDataSource. (Closed)

Created:
4 years, 9 months ago by xhwang
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Update PipelineIntegrationTestBase to support MemoryDataSource. BUG=584119 TEST=Improve test infrastructure. No functionality change. Committed: https://crrev.com/68403dc18553e0420a76cabdc4d6cc88604fea5f Cr-Commit-Position: refs/heads/master@{#378623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -35 lines) Patch
M media/test/pipeline_integration_test_base.h View 4 chunks +24 lines, -13 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 6 chunks +46 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xhwang
The second CL. PTAL!
4 years, 9 months ago (2016-03-01 22:44:56 UTC) #2
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-01 23:11:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757593002/1
4 years, 9 months ago (2016-03-01 23:20:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 00:20:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 00:21:13 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/68403dc18553e0420a76cabdc4d6cc88604fea5f
Cr-Commit-Position: refs/heads/master@{#378623}

Powered by Google App Engine
This is Rietveld 408576698