Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1757583002: Fix bookmark search row height issue that was cutting off text. (Closed)

Created:
4 years, 9 months ago by Pete Williamson
Modified:
4 years, 9 months ago
Reviewers:
Ted C, Ian Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bookmark search row height issue that was cutting off text. BUG=582024 Committed: https://crrev.com/357a00d03ba2e7cef17c700e0346196694f3c01b Cr-Commit-Position: refs/heads/master@{#379039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/res/layout/bookmark_search_row.xml View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Pete Williamson
We have a similar problem with the bookmark search when displaying sizes that we had ...
4 years, 9 months ago (2016-03-01 21:24:54 UTC) #2
Ian Wen
lgtm. You need a resource folder owner (tedchoc@ here) to review it also.
4 years, 9 months ago (2016-03-02 01:02:25 UTC) #4
Ted C
lgtm
4 years, 9 months ago (2016-03-03 15:40:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757583002/1
4 years, 9 months ago (2016-03-03 17:04:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 18:22:53 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 18:23:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/357a00d03ba2e7cef17c700e0346196694f3c01b
Cr-Commit-Position: refs/heads/master@{#379039}

Powered by Google App Engine
This is Rietveld 408576698