Issue 17570014: [SPDY] Unfork websocket_handshake_handler_spdy{2,3}_unittest.cc

Issue 17570014: [SPDY] Unfork websocket_handshake_handler_spdy{2,3}_unittest.cc (Closed)

Created:
7 years, 6 months ago by akalin

Modified:
7 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SPDY] Unfork websocket_handshake_handler_spdy{2,3}_unittest.cc BUG=226192 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208514

Patch Set 2 : Address comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -412 lines)			Patch
M	net/net.gyp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	net/spdy/spdy_websocket_test_util.h	View		3 chunks	+12 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_websocket_test_util.cc	View		2 chunks	+16 lines, -1 line	0 comments	Download
D	net/websockets/websocket_handshake_handler_spdy2_unittest.cc	View		1 chunk	+0 lines, -176 lines	0 comments	Download
D	net/websockets/websocket_handshake_handler_spdy3_unittest.cc	View		1 chunk	+0 lines, -183 lines	0 comments	Download
A +	net/websockets/websocket_handshake_handler_spdy_unittest.cc	View	1	7 chunks	+62 lines, -48 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/17570014/diff/1/net/websockets/websocket_handshake_handler_spdy_unittest.cc File net/websockets/websocket_handshake_handler_spdy_unittest.cc (right): https://codereview.chromium.org/17570014/diff/1/net/websockets/websocket_handshake_handler_spdy_unittest.cc#newcode91 net/websockets/websocket_handshake_handler_spdy_unittest.cc:91: spdy_util_.spdy_version())); nit: can all 3 of these fit ...

7 years, 6 months ago (2013-06-25 02:51:49 UTC) #2

akalin

Done, committing https://codereview.chromium.org/17570014/diff/1/net/websockets/websocket_handshake_handler_spdy_unittest.cc File net/websockets/websocket_handshake_handler_spdy_unittest.cc (right): https://codereview.chromium.org/17570014/diff/1/net/websockets/websocket_handshake_handler_spdy_unittest.cc#newcode91 net/websockets/websocket_handshake_handler_spdy_unittest.cc:91: spdy_util_.spdy_version())); On 2013/06/25 02:51:49, Ryan Hamilton wrote: ...

7 years, 6 months ago (2013-06-25 15:59:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/17570014/18001

7 years, 6 months ago (2013-06-25 15:59:30 UTC) #4

akalin

7 years, 6 months ago (2013-06-25 17:17:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r208514 (presubmit successful).

Expand Messages | Collapse Messages