chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm - Issue 17567007: Made MessagePump a non-thread safe class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm

Issue 17567007: Made MessagePump a non-thread safe class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/message_loop/message_loop.cc ('K') | « chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm

index 5ec022f72ca4c3656a067eed37d17484b9909c9f..1fd2d9e1509de25677414faa838057c90ac0604d 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include "base/mac/scoped_nsobject.h"

+#include "base/memory/scoped_ptr.h"

#include "base/message_loop/message_pump_mac.h"

#import "chrome/browser/ui/cocoa/cocoa_test_helper.h"

#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_animation.h"

@@ -12,7 +13,7 @@

<NSAnimationDelegate> {

@private

CGFloat frameCount_;

- scoped_refptr<base::MessagePumpNSRunLoop> message_pump_;

+ scoped_ptr<base::MessagePumpNSRunLoop> message_pump_;

}

- (void)runAnimation:(NSAnimation*)animation;

@@ -23,7 +24,7 @@

- (id)init {

if ((self = [super init]))

- message_pump_ = new base::MessagePumpNSRunLoop;

+ message_pump_.reset(new base::MessagePumpNSRunLoop);

return self;

}