Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: base/message_loop/message_pump_io_ios_unittest.cc

Issue 17567007: Made MessagePump a non-thread safe class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/message_loop/message_pump_io_ios_unittest.cc
diff --git a/base/message_loop/message_pump_io_ios_unittest.cc b/base/message_loop/message_pump_io_ios_unittest.cc
index 5fbba6968e6251e79b680b469091bda44c794c91..9c7a8fbf651fb851abc3c14e88496a5d7b232a98 100644
--- a/base/message_loop/message_pump_io_ios_unittest.cc
+++ b/base/message_loop/message_pump_io_ios_unittest.cc
@@ -126,7 +126,7 @@ class DeleteWatcher : public BaseWatcher {
};
TEST_F(MessagePumpIOSForIOTest, DeleteWatcher) {
- scoped_refptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
+ scoped_ptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
MessagePumpIOSForIO::FileDescriptorWatcher* watcher =
new MessagePumpIOSForIO::FileDescriptorWatcher;
DeleteWatcher delegate(watcher);
@@ -162,9 +162,9 @@ class StopWatcher : public BaseWatcher {
};
TEST_F(MessagePumpIOSForIOTest, StopWatcher) {
- scoped_refptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
+ scoped_ptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
MessagePumpIOSForIO::FileDescriptorWatcher watcher;
- StopWatcher delegate(&watcher, pump);
+ StopWatcher delegate(&watcher, pump.get());
pump->WatchFileDescriptor(pipefds_[1],
false, MessagePumpIOSForIO::WATCH_READ_WRITE, &watcher, &delegate);
@@ -173,9 +173,9 @@ TEST_F(MessagePumpIOSForIOTest, StopWatcher) {
}
TEST_F(MessagePumpIOSForIOTest, StopWatcherAndWatchSomethingElse) {
- scoped_refptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
+ scoped_ptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
MessagePumpIOSForIO::FileDescriptorWatcher watcher;
- StopWatcher delegate(&watcher, pump, alternate_pipefds_[1]);
+ StopWatcher delegate(&watcher, pump.get(), alternate_pipefds_[1]);
pump->WatchFileDescriptor(pipefds_[1],
false, MessagePumpIOSForIO::WATCH_READ_WRITE, &watcher, &delegate);

Powered by Google App Engine
This is Rietveld 408576698