Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1865)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 17564007: Clean up remaining DumpRenderTree references and flags. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix handling of the default None option for --driver-name Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py b/Tools/Scripts/webkitpy/layout_tests/port/base.py
index b6fa8a1c30815dd1606e685dbf71cfd7c65af25e..de3fe26788a02e360de2d76d8dcea4fa59b1d58f 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -185,7 +185,7 @@ class Port(object):
return self.get_option('retry_crashes', False)
def default_child_processes(self):
- """Return the number of DumpRenderTree instances to use for this port."""
+ """Return the number of drivers to use for this port."""
return self._executive.cpu_count()
def default_max_locked_shards(self):
@@ -380,8 +380,6 @@ class Port(object):
def driver_name(self):
if self.get_option('driver_name'):
return self.get_option('driver_name')
- if self.get_option('dump_render_tree'):
- return 'DumpRenderTree'
return self.CONTENT_SHELL_NAME
def expected_baselines_by_extension(self, test_name):
@@ -1221,7 +1219,7 @@ class Port(object):
return self._filesystem.join(self._filesystem.abspath(root_directory), *comps)
def _path_to_driver(self, configuration=None):
- """Returns the full path to the test driver (DumpRenderTree)."""
+ """Returns the full path to the test driver."""
return self._build_path(self.driver_name())
def _path_to_webcore_library(self):

Powered by Google App Engine
This is Rietveld 408576698