Tools/Scripts/webkitpy/layout_tests/models/test_failures.py - Issue 17564007: Clean up remaining DumpRenderTree references and flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

Issue 17564007: Clean up remaining DumpRenderTree references and flags. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix handling of the default None option for --driver-name Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py b/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

index 52b72085403bd86b0a7f48257e46a5d75ea09c08..f7978217cb991a062ef92223b2c06ada388b54c9 100644

--- a/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

@@ -104,7 +104,7 @@ class TestFailure(object):

return cPickle.dumps(self)

def driver_needs_restart(self):

- """Returns True if we should kill DumpRenderTree/WebKitTestRunner before the next test."""

+ """Returns True if we should kill the driver before the next test."""

return False

@@ -121,7 +121,7 @@ class FailureTimeout(TestFailure):

class FailureCrash(TestFailure):

- def __init__(self, is_reftest=False, process_name='DumpRenderTree', pid=None):

+ def __init__(self, is_reftest=False, process_name='content_shell', pid=None):

super(FailureCrash, self).__init__()

self.process_name = process_name

self.pid = pid