Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/test.py

Issue 17564007: Clean up remaining DumpRenderTree references and flags. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix handling of the default None option for --driver-name Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 return self.ALL_BASELINE_VARIANTS 530 return self.ALL_BASELINE_VARIANTS
531 531
532 def virtual_test_suites(self): 532 def virtual_test_suites(self):
533 return [ 533 return [
534 VirtualTestSuite('virtual/passes', 'passes', ['--virtual-arg']), 534 VirtualTestSuite('virtual/passes', 'passes', ['--virtual-arg']),
535 VirtualTestSuite('virtual/skipped', 'failures/expected', ['--virtual -arg2']), 535 VirtualTestSuite('virtual/skipped', 'failures/expected', ['--virtual -arg2']),
536 ] 536 ]
537 537
538 538
539 class TestDriver(Driver): 539 class TestDriver(Driver):
540 """Test/Dummy implementation of the DumpRenderTree interface.""" 540 """Test/Dummy implementation of the driver interface."""
541 next_pid = 1 541 next_pid = 1
542 542
543 def __init__(self, *args, **kwargs): 543 def __init__(self, *args, **kwargs):
544 super(TestDriver, self).__init__(*args, **kwargs) 544 super(TestDriver, self).__init__(*args, **kwargs)
545 self.started = False 545 self.started = False
546 self.pid = 0 546 self.pid = 0
547 547
548 def cmd_line(self, pixel_tests, per_test_args): 548 def cmd_line(self, pixel_tests, per_test_args):
549 pixel_tests_flag = '-p' if pixel_tests else '' 549 pixel_tests_flag = '-p' if pixel_tests else ''
550 return [self._port._path_to_driver()] + [pixel_tests_flag] + self._port. get_option('additional_drt_flag', []) + per_test_args 550 return [self._port._path_to_driver()] + [pixel_tests_flag] + self._port. get_option('additional_drt_flag', []) + per_test_args
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 image = None 606 image = None
607 else: 607 else:
608 image = test.actual_image 608 image = test.actual_image
609 return DriverOutput(actual_text, image, test.actual_checksum, audio, 609 return DriverOutput(actual_text, image, test.actual_checksum, audio,
610 crash=test.crash or test.web_process_crash, crashed_process_name=cra shed_process_name, 610 crash=test.crash or test.web_process_crash, crashed_process_name=cra shed_process_name,
611 crashed_pid=crashed_pid, crash_log=crash_log, 611 crashed_pid=crashed_pid, crash_log=crash_log,
612 test_time=time.time() - start_time, timeout=test.timeout, error=test .error, pid=self.pid) 612 test_time=time.time() - start_time, timeout=test.timeout, error=test .error, pid=self.pid)
613 613
614 def stop(self): 614 def stop(self):
615 self.started = False 615 self.started = False
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/server_process.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698