Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 17563002: Add the SetMediaKeys handler to pass a drm bridge to a MediaSourcePlayer (Closed)

Created:
7 years, 6 months ago by qinmin
Modified:
7 years, 6 months ago
Reviewers:
xhwang
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add the SetMediaKeys handler to pass a drm bridge to a MediaSourcePlayer Adding the message handler so people can work on it. BUG=163552 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208072

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M content/browser/android/media_player_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/media_player_manager_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M media/base/android/media_player_android.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/base/android/media_player_android.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M media/base/android/media_source_player.h View 2 chunks +3 lines, -6 lines 0 comments Download
M media/base/android/media_source_player.cc View 2 chunks +9 lines, -1 line 2 comments Download

Messages

Total messages: 10 (0 generated)
qinmin
PTAL
7 years, 6 months ago (2013-06-21 19:57:51 UTC) #1
xhwang
LGTM https://codereview.chromium.org/17563002/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (right): https://codereview.chromium.org/17563002/diff/1/media/base/android/media_source_player.cc#newcode479 media/base/android/media_source_player.cc:479: // to pass the drm_bridge to the decoder ...
7 years, 6 months ago (2013-06-21 20:45:11 UTC) #2
qinmin
https://codereview.chromium.org/17563002/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (right): https://codereview.chromium.org/17563002/diff/1/media/base/android/media_source_player.cc#newcode479 media/base/android/media_source_player.cc:479: // to pass the drm_bridge to the decoder jobs. ...
7 years, 6 months ago (2013-06-21 20:53:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/17563002/1
7 years, 6 months ago (2013-06-21 21:00:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/17563002/1
7 years, 6 months ago (2013-06-22 02:47:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/17563002/1
7 years, 6 months ago (2013-06-22 03:10:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/17563002/1
7 years, 6 months ago (2013-06-22 03:23:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/17563002/1
7 years, 6 months ago (2013-06-22 03:38:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/17563002/1
7 years, 6 months ago (2013-06-22 03:44:47 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 17:09:50 UTC) #10
Message was sent while issue was closed.
Change committed as 208072

Powered by Google App Engine
This is Rietveld 408576698