Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 17560002: [telemetry] Remove all pyc files before doing presumibit work (Closed)

Created:
7 years, 6 months ago by nduca
Modified:
7 years, 6 months ago
Reviewers:
achuithb, dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Remove all pyc files before doing presumibit work Avoids presubmit failures when stale pyc files are found NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207955

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/telemetry/build/update_docs.py View 1 2 chunks +11 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
nduca
7 years, 6 months ago (2013-06-21 18:59:51 UTC) #1
tonyg
lgtm I think the discover code may need to do the same thing https://codereview.chromium.org/17560002/diff/1/tools/telemetry/build/update_docs.py File ...
7 years, 6 months ago (2013-06-21 19:02:38 UTC) #2
dtu
On 2013/06/21 19:02:38, tonyg wrote: > lgtm > > I think the discover code may ...
7 years, 6 months ago (2013-06-21 19:29:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/17560002/6001
7 years, 6 months ago (2013-06-21 23:25:35 UTC) #4
commit-bot: I haz the power
Change committed as 207955
7 years, 6 months ago (2013-06-21 23:31:55 UTC) #5
achuithb
https://chromiumcodereview.appspot.com/17560002/diff/6001/tools/telemetry/build/update_docs.py File tools/telemetry/build/update_docs.py (right): https://chromiumcodereview.appspot.com/17560002/diff/6001/tools/telemetry/build/update_docs.py#newcode34 tools/telemetry/build/update_docs.py:34: os.remove(py_path) SHouldn't this be pyc_path?
7 years, 6 months ago (2013-06-24 22:05:06 UTC) #6
dtu
7 years, 6 months ago (2013-06-24 22:14:37 UTC) #7
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/17560002/diff/6001/tools/telemetry/bui...
File tools/telemetry/build/update_docs.py (right):

https://chromiumcodereview.appspot.com/17560002/diff/6001/tools/telemetry/bui...
tools/telemetry/build/update_docs.py:34: os.remove(py_path)
On 2013/06/24 22:05:06, achuith.bhandarkar wrote:
> SHouldn't this be pyc_path?

lol yes, you're right

Powered by Google App Engine
This is Rietveld 408576698