Set default pinch viewport overlay scrollbar thickness in WebPreferences.

Set default pinch viewport overlay scrollbar thickness in WebPreferences.

WebSettings defaults this value to 0, so we need to set the default value in
WebPreferences.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208076

[wjmaclean, 2013-06-21 17:58:18]

Small patch to set default thickness for pinch viewport overlay scrollbars.

[jamesr, 2013-06-21 18:04:04]

Shouldn't the client configuring pinch viewport scrollbars set these?  In most
embedding situations we won't even have these things, so it doesn't make sense
to me to provide a width for them.

[wjmaclean, 2013-06-21 18:19:18]

On 2013/06/21 18:04:04, jamesr wrote:
> Shouldn't the client configuring pinch viewport scrollbars set these?  In most
> embedding situations we won't even have these things, so it doesn't make sense
> to me to provide a width for them.

Hmm, I'm not sure who we're considering to be the 'client' here. On the previous
CL the reviewers asked to make this parameter a WebSetting, so I though this was
the natural entry point (since in WebSettingImpl we default the value to 0)

[jamesr, 2013-06-21 18:37:42]

On 2013/06/21 18:19:18, wjmaclean wrote:
> On 2013/06/21 18:04:04, jamesr wrote:
> > Shouldn't the client configuring pinch viewport scrollbars set these?  In
most
> > embedding situations we won't even have these things, so it doesn't make
sense
> > to me to provide a width for them.
> 
> Hmm, I'm not sure who we're considering to be the 'client' here. On the
previous
> CL the reviewers asked to make this parameter a WebSetting, so I though this
was
> the natural entry point (since in WebSettingImpl we default the value to 0)

Whichever code is responsible for deciding whether to use pinch viewport
scrollbars.  I'm guessing this will be up in content/ or chrome/ and be based
off of some combination of command line flags, platform capabilities, etc.

[wjmaclean, 2013-06-21 19:09:40]

Ahh, OK. The enabling flag is handled in WebContentsImpl, so I've move setting
the default value there.

[jamesr, 2013-06-21 19:11:35]

https://codereview.chromium.org/17558002/diff/6001/content/browser/web_conten...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/17558002/diff/6001/content/browser/web_conten...
content/browser/web_contents/web_contents_impl.cc:555:
prefs.pinch_overlay_scrollbar_thickness = 10;
if we don't have pinch viewport enabled, why set the thickness?

[wjmaclean, 2013-06-21 19:37:12]

This version only sets the value when the pinch virtual viewport is enabled.
PTAL.

[jamesr, 2013-06-21 19:38:30]

lgtm

[commit-bot: I haz the power, 2013-06-21 19:40:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17558002/12001

[commit-bot: I haz the power, 2013-06-21 19:50:05]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[sky, 2013-06-21 20:17:16]

LGTM

[commit-bot: I haz the power, 2013-06-21 20:19:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17558002/12001

[commit-bot: I haz the power, 2013-06-22 02:46:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17558002/12001

[commit-bot: I haz the power, 2013-06-22 03:09:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17558002/12001

[commit-bot: I haz the power, 2013-06-22 03:22:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17558002/12001

[commit-bot: I haz the power, 2013-06-22 03:38:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17558002/12001

[commit-bot: I haz the power, 2013-06-22 03:44:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17558002/12001

[commit-bot: I haz the power, 2013-06-22 17:20:12]

Change committed as 208076