Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 17551012: Fix error handling when download of component updates fails. This line (Closed)

Created:
7 years, 6 months ago by Sorin Jianu
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

Fix error handling when download of component updates fails. This line was lost during refactoring of error handling for issue 15908002. Added missing crx->diff_update_failed = true; BUG=245318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/component_updater/component_updater_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
asargent_no_longer_on_chrome
lgtm
7 years, 6 months ago (2013-06-21 21:43:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/17551012/1
7 years, 6 months ago (2013-06-21 21:45:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/17551012/1
7 years, 6 months ago (2013-06-22 02:46:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/17551012/1
7 years, 6 months ago (2013-06-22 03:09:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/17551012/1
7 years, 6 months ago (2013-06-22 03:22:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/17551012/1
7 years, 6 months ago (2013-06-22 03:36:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/17551012/1
7 years, 6 months ago (2013-06-22 03:44:13 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 15:22:35 UTC) #8
Message was sent while issue was closed.
Change committed as 208056

Powered by Google App Engine
This is Rietveld 408576698