Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 17550003: Set multi-line attribute on the label before call SizeToFit to avoid DCHECK-ing. (Closed)

Created:
7 years, 6 months ago by pastarmovj
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Set multi-line attribute on the label before call SizeToFit to avoid DCHECK-ing. BUG=252667 TEST=No dchecking on calls to LabelTrayView::CreateChildView from ChromeOS. TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207915

Patch Set 1 #

Patch Set 2 : Of course don't call stuff on the text label before it is created. :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ash/system/chromeos/label_tray_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Denis Kuznetsov (DE-MUC)
lgtm
7 years, 6 months ago (2013-06-21 12:25:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/17550003/1
7 years, 6 months ago (2013-06-21 12:34:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/17550003/3
7 years, 6 months ago (2013-06-21 14:41:13 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 20:27:12 UTC) #4
Message was sent while issue was closed.
Change committed as 207915

Powered by Google App Engine
This is Rietveld 408576698