Suppress lints on synthetic nodes/tokens (#193).

Suppress lints on synthetic nodes/tokens (#193).

Fixes https://github.com/dart-lang/linter/issues/193.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/linter/commit/f90572f9be203a0ec9744aa3fb3b9509e3ca143d

[pquitslund, 2016-03-01 21:11:21]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-03-01 21:26:54]

LGTM

https://codereview.chromium.org/1754813003/diff/1/lib/src/linter.dart
File lib/src/linter.dart (right):

https://codereview.chromium.org/1754813003/diff/1/lib/src/linter.dart#newcode271
lib/src/linter.dart:271: if (token != null && (!token.isSynthetic ||
!ignoreSyntheticTokens)) {
Interesting. In the parser, when we're not ignoring synthetic tokens, we attach
the error to the first non-synthetic token preceding the synthetic one because
synthetic tokens always have a length of zero.

https://codereview.chromium.org/1754813003/diff/1/test/_data/synthetic/synthe...
File test/_data/synthetic/synthetic.dart (right):

https://codereview.chromium.org/1754813003/diff/1/test/_data/synthetic/synthe...
test/_data/synthetic/synthetic.dart:2: // `XXX` below is synthetic
That can't be true because synthetic tokens are always zero length. I think
what's happening is that we're inserting a synthetic token after 'XXX' and
that's what's causing the lint to fire.

[pquitslund, 2016-03-01 21:30:02]

Thanks!

Let me know if you think I should remove the logic around tokens...

https://codereview.chromium.org/1754813003/diff/1/lib/src/linter.dart
File lib/src/linter.dart (right):

https://codereview.chromium.org/1754813003/diff/1/lib/src/linter.dart#newcode271
lib/src/linter.dart:271: if (token != null && (!token.isSynthetic ||
!ignoreSyntheticTokens)) {
On 2016/03/01 21:26:54, Brian Wilkerson wrote:
> Interesting. In the parser, when we're not ignoring synthetic tokens, we
attach
> the error to the first non-synthetic token preceding the synthetic one because
> synthetic tokens always have a length of zero.

Hmmmm.  That is interesting.  Maybe I should just remove this logic?  I'm only
seeing the synthetic nodes in the wild anyway...

https://codereview.chromium.org/1754813003/diff/1/test/_data/synthetic/synthe...
File test/_data/synthetic/synthetic.dart (right):

https://codereview.chromium.org/1754813003/diff/1/test/_data/synthetic/synthe...
test/_data/synthetic/synthetic.dart:2: // `XXX` below is synthetic
On 2016/03/01 21:26:54, Brian Wilkerson wrote:
> That can't be true because synthetic tokens are always zero length. I think
> what's happening is that we're inserting a synthetic token after 'XXX' and
> that's what's causing the lint to fire.

You're right!  I just figured that out myself (see screenshot here:
https://github.com/dart-lang/sdk/issues/25876).

Will fix.

[Brian Wilkerson, 2016-03-01 21:38:55]

https://codereview.chromium.org/1754813003/diff/1/lib/src/linter.dart
File lib/src/linter.dart (right):

https://codereview.chromium.org/1754813003/diff/1/lib/src/linter.dart#newcode271
lib/src/linter.dart:271: if (token != null && (!token.isSynthetic ||
!ignoreSyntheticTokens)) {
> Hmmmm.  That is interesting.  Maybe I should just remove this logic?  I'm only
> seeing the synthetic nodes in the wild anyway...

It seems consistent to disable lints on synthetic tokens; some future lints will
undoubtedly want to report against non-identifier tokens.

But given that synthetic tokens always have zero length, it's kind of hard for
editors to highlight them. Maybe just a TODO for now so that we don't forget.

[pquitslund, 2016-03-01 22:03:49]

Description was changed from

==========
Suppress lints on synthetic nodes/tokens (#193).

Fixes https://github.com/dart-lang/linter/issues/193.

BUG=
==========

to

==========
Suppress lints on synthetic nodes/tokens (#193).

Fixes https://github.com/dart-lang/linter/issues/193.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/linter/commit/f90572f9be203a0ec9744aa3fb3b9509e3...
==========

[pquitslund, 2016-03-01 22:03:51]

Committed patchset #2 (id:20001) manually as
f90572f9be203a0ec9744aa3fb3b9509e3ca143d (presubmit successful).