Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 17546004: Added policy for disabling locally managed users. (Closed)

Created:
7 years, 6 months ago by dzhioev (left Google)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Added policy for disabling locally managed users. By default LMU disabled for managed devices. Also added support of new policy in ChromeOS part. BUG=229298 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207978

Patch Set 1 #

Patch Set 2 : Little fix. #

Total comments: 18

Patch Set 3 : Some remarks fixed. #

Total comments: 11

Patch Set 4 : Comments addressed. #

Total comments: 4

Patch Set 5 : s/locally managed/supervised/ in new code. Policy description changed. #

Patch Set 6 : Policy definition fixed. #

Patch Set 7 : Merge conflict resolved. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -35 lines) Patch
M chrome/app/policy/policy_templates.json View 1 2 3 4 5 6 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 2 3 9 chunks +24 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_unittest.cc View 1 2 3 8 chunks +32 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 2 3 4 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/policy/proto/chromeos/chrome_device_policy.proto View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 6 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
dzhioev (left Google)
Hi, please take a look. Denis, ChromeOS part. Mattias, policy and ChromeOS settings. Bernhard, check ...
7 years, 6 months ago (2013-06-21 11:04:20 UTC) #1
Bernhard Bauer
https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json#newcode4888 chrome/app/policy/policy_templates.json:4888: 'supported_on': ['chrome:29-', 'chrome_os:29-'], Is this policy really supported on ...
7 years, 6 months ago (2013-06-21 11:59:25 UTC) #2
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json#newcode4885 chrome/app/policy/policy_templates.json:4885: 'name': 'LocallyManagedUsersEnabled', As final name for feature is "Supervised ...
7 years, 6 months ago (2013-06-21 12:28:52 UTC) #3
dzhioev (left Google)
https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json#newcode4888 chrome/app/policy/policy_templates.json:4888: 'supported_on': ['chrome:29-', 'chrome_os:29-'], On 2013/06/21 11:59:25, Bernhard Bauer wrote: ...
7 years, 6 months ago (2013-06-21 13:13:23 UTC) #4
dzhioev (left Google)
https://codereview.chromium.org/17546004/diff/3001/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): https://codereview.chromium.org/17546004/diff/3001/chrome/browser/chromeos/login/existing_user_controller.cc#newcode184 chrome/browser/chromeos/login/existing_user_controller.cc:184: if (((*it)->GetType() != User::USER_TYPE_LOCALLY_MANAGED || On 2013/06/21 12:28:52, Denis ...
7 years, 6 months ago (2013-06-21 13:42:29 UTC) #5
Mattias Nissler (ping if slow)
policy bits LGTM w/ nits. https://codereview.chromium.org/17546004/diff/13001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/13001/chrome/app/policy/policy_templates.json#newcode4896 chrome/app/policy/policy_templates.json:4896: 'desc': '''If this policy ...
7 years, 6 months ago (2013-06-21 14:25:16 UTC) #6
Bernhard Bauer
https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json#newcode4888 chrome/app/policy/policy_templates.json:4888: 'supported_on': ['chrome:29-', 'chrome_os:29-'], On 2013/06/21 13:13:24, dzhioev wrote: > ...
7 years, 6 months ago (2013-06-21 14:38:35 UTC) #7
Mattias Nissler (ping if slow)
https://codereview.chromium.org/17546004/diff/13001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/13001/chrome/app/policy/policy_templates.json#newcode4888 chrome/app/policy/policy_templates.json:4888: 'supported_on': ['chrome:29-', 'chrome_os:29-'], One more thing: I don't see ...
7 years, 6 months ago (2013-06-21 14:41:16 UTC) #8
dzhioev (left Google)
On 2013/06/21 14:38:35, Bernhard Bauer wrote: > https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json > File chrome/app/policy/policy_templates.json (right): > > https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json#newcode4888 ...
7 years, 6 months ago (2013-06-21 14:52:51 UTC) #9
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/17546004/diff/13001/chrome/browser/chromeos/settings/cros_settings_names.cc File chrome/browser/chromeos/settings/cros_settings_names.cc (right): https://chromiumcodereview.appspot.com/17546004/diff/13001/chrome/browser/chromeos/settings/cros_settings_names.cc#newcode36 chrome/browser/chromeos/settings/cros_settings_names.cc:36: "cros.accounts.locallyManagedUsersEnabled"; Please rename to Supervised user.
7 years, 6 months ago (2013-06-21 15:46:56 UTC) #10
Mattias Nissler (ping if slow)
On 2013/06/21 14:52:51, dzhioev wrote: > On 2013/06/21 14:38:35, Bernhard Bauer wrote: > > > ...
7 years, 6 months ago (2013-06-21 16:29:25 UTC) #11
dzhioev (left Google)
https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/3001/chrome/app/policy/policy_templates.json#newcode4885 chrome/app/policy/policy_templates.json:4885: 'name': 'LocallyManagedUsersEnabled', On 2013/06/21 12:28:52, Denis Kuznetsov wrote: > ...
7 years, 6 months ago (2013-06-21 16:48:17 UTC) #12
Denis Kuznetsov (DE-MUC)
lgtm
7 years, 6 months ago (2013-06-21 17:06:16 UTC) #13
Bernhard Bauer
LGTM w/ nits: https://codereview.chromium.org/17546004/diff/13003/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/13003/chrome/app/policy/policy_templates.json#newcode4896 chrome/app/policy/policy_templates.json:4896: 'desc': '''If set to true, supervised ...
7 years, 6 months ago (2013-06-21 17:16:14 UTC) #14
dzhioev (left Google)
https://codereview.chromium.org/17546004/diff/13003/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://codereview.chromium.org/17546004/diff/13003/chrome/app/policy/policy_templates.json#newcode4896 chrome/app/policy/policy_templates.json:4896: 'desc': '''If set to true, supervised users can be ...
7 years, 6 months ago (2013-06-21 17:25:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/17546004/16002
7 years, 6 months ago (2013-06-21 17:26:42 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-21 17:41:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/17546004/8018
7 years, 6 months ago (2013-06-21 17:58:24 UTC) #18
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=141592
7 years, 6 months ago (2013-06-21 19:09:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/17546004/8018
7 years, 6 months ago (2013-06-21 19:26:47 UTC) #20
commit-bot: I haz the power
Failed to apply patch for chrome/app/policy/policy_templates.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-21 19:26:50 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/17546004/41001
7 years, 6 months ago (2013-06-21 20:03:23 UTC) #22
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 00:38:16 UTC) #23
Message was sent while issue was closed.
Change committed as 207978

Powered by Google App Engine
This is Rietveld 408576698