Issue 17546002: Support SetFocusedTextInputClient(NULL) in InputMethodTSF

Issue 17546002: Support SetFocusedTextInputClient(NULL) in InputMethodTSF (Closed)

Created:
7 years, 6 months ago by Yohei Yukawa

Modified:
7 years, 6 months ago

Reviewers:
Yohei Yukawa, Seigo Nonaka

CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, kochi, Yuki, yoichio

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Support SetFocusedTextInputClient(NULL) in InputMethodTSF. It turned out that the previous implementation of InputMethodTSF did not support InputMethodTSF::SetFocusedTextInputClient(NULL). This CL fixes the issue. BUG=246534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208043

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	ui/base/ime/input_method_tsf.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

lgtm https://codereview.chromium.org/17546002/diff/4001/ui/base/ime/input_method_tsf.cc File ui/base/ime/input_method_tsf.cc (right): https://codereview.chromium.org/17546002/diff/4001/ui/base/ime/input_method_tsf.cc#newcode97 ui/base/ime/input_method_tsf.cc:97: ui::TSFBridge::GetInstance()->RemoveFocusedClient(focused_client); can be follows? ui::TSFBridge::GetInstance()->RemoveFocusedClient( ui::TSFBridge::GetInstance()->GetFocusedTextInputClient());

7 years, 6 months ago (2013-06-21 12:12:38 UTC) #2

Yohei Yukawa

https://codereview.chromium.org/17546002/diff/4001/ui/base/ime/input_method_tsf.cc File ui/base/ime/input_method_tsf.cc (right): https://codereview.chromium.org/17546002/diff/4001/ui/base/ime/input_method_tsf.cc#newcode97 ui/base/ime/input_method_tsf.cc:97: ui::TSFBridge::GetInstance()->RemoveFocusedClient(focused_client); On 2013/06/21 12:12:38, Seigo Nonaka wrote: > can ...

7 years, 6 months ago (2013-06-22 10:46:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/17546002/9001

7 years, 6 months ago (2013-06-22 10:48:09 UTC) #4

Message was sent while issue was closed.

Change committed as 208043

Expand Messages | Collapse Messages