Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17542002: Add theme tab background images. (Closed)

Created:
7 years, 6 months ago by Adrian Kuegel
Modified:
7 years, 6 months ago
Reviewers:
pkotwicz, oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Add theme tab background images. This CL adds tab background images for the managed user theme. The bug description shows a screenshot. BUG=241377 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208057

Patch Set 1 : Add theme tab background images. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/app/theme/theme_resources.grd View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Adrian Kuegel
@Mitsuru: can you please review theme_resources.grd? @Peter: can you please review theme_service.cc?
7 years, 6 months ago (2013-06-21 14:40:49 UTC) #1
oshima
chrome/app/theme lgtm
7 years, 6 months ago (2013-06-21 14:53:21 UTC) #2
pkotwicz
LGTM
7 years, 6 months ago (2013-06-21 21:41:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/17542002/12003
7 years, 6 months ago (2013-06-21 21:42:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/17542002/12003
7 years, 6 months ago (2013-06-22 02:46:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/17542002/12003
7 years, 6 months ago (2013-06-22 03:08:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/17542002/12003
7 years, 6 months ago (2013-06-22 03:21:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/17542002/12003
7 years, 6 months ago (2013-06-22 03:36:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/17542002/12003
7 years, 6 months ago (2013-06-22 03:44:00 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 15:28:56 UTC) #10
Message was sent while issue was closed. 
Change committed as 208057

Powered by Google App Engine
This is Rietveld 408576698