Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 17527004: Augment mffr.py to be able to take arguments from a file. (Closed)

Created:
7 years, 6 months ago by blundell
Modified:
7 years, 6 months ago
Reviewers:
Jói
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Augment mffr.py to be able to take arguments from a file. Example use case is iterating on follow-up changes to a file changing namespaces, impacting all the symbols within that file. R=joi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207883

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -24 lines) Patch
M tools/git/mffr.py View 1 3 chunks +77 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blundell
7 years, 6 months ago (2013-06-21 09:43:59 UTC) #1
Jói
LGTM with a nit. https://codereview.chromium.org/17527004/diff/1/tools/git/mffr.py File tools/git/mffr.py (right): https://codereview.chromium.org/17527004/diff/1/tools/git/mffr.py#newcode82 tools/git/mffr.py:82: <file> should contain a list ...
7 years, 6 months ago (2013-06-21 11:29:35 UTC) #2
blundell
https://codereview.chromium.org/17527004/diff/1/tools/git/mffr.py File tools/git/mffr.py (right): https://codereview.chromium.org/17527004/diff/1/tools/git/mffr.py#newcode82 tools/git/mffr.py:82: <file> should contain a list of [REGEXP, REPLACEMENT, [GLOBS]] ...
7 years, 6 months ago (2013-06-21 13:33:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/17527004/5001
7 years, 6 months ago (2013-06-21 15:18:24 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 18:23:05 UTC) #5
Message was sent while issue was closed.
Change committed as 207883

Powered by Google App Engine
This is Rietveld 408576698