chrome/common/extensions/extension_messages.h - Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation

Unified Diff: chrome/common/extensions/extension_messages.h

Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/tab_helper.cc ('K') | « chrome/common/extensions/api/webstore/webstore_api_constants.cc ('k') | chrome/renderer/extensions/webstore_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_messages.h

diff --git a/chrome/common/extensions/extension_messages.h b/chrome/common/extensions/extension_messages.h

index c1167743d307d9b325d73941d26f0f741dab54ff..be92d1a97f88866c581ff53d2f82e782705c9bdb 100644

--- a/chrome/common/extensions/extension_messages.h

+++ b/chrome/common/extensions/extension_messages.h

@@ -601,11 +601,22 @@ IPC_MESSAGE_ROUTED2(ExtensionHostMsg_DidGetApplicationInfo,

WebApplicationInfo)

// Sent by the renderer to implement chrome.webstore.install().

-IPC_MESSAGE_ROUTED4(ExtensionHostMsg_InlineWebstoreInstall,

+IPC_MESSAGE_ROUTED5(ExtensionHostMsg_InlineWebstoreInstall,

int32 /* install id */,

int32 /* return route id */,

std::string /* Web Store item ID */,

- GURL /* requestor URL */)

+ GURL /* requestor URL */,

+ int /* listeners_mask */)

+// Sent to the renderer if install stage updates were requested for an inline

+// install.

+IPC_MESSAGE_ROUTED1(ExtensionMsg_InlineInstallStageChanged,

+ std::string /* stage */)

jln (very slow on Chromium) 2014/03/10 23:35:41 Could you make this an enum instad of a string? W

Devlin 2014/03/11 17:22:06 Done, and thanks for the tip! :)

jln (very slow on Chromium) 2014/03/20 00:05:40 Sorry, I should have been more clear. You need to

Devlin 2014/03/20 16:54:37 Ah, I see. Like this?

+// Sent to the renderer if download progress updates were requested for an

+// inline install.

+IPC_MESSAGE_ROUTED1(ExtensionMsg_InlineInstallDownloadProgress,

+ int /* percent_downloaded */)

// Sent by the renderer when a web page is checking if its app is installed.

IPC_MESSAGE_ROUTED3(ExtensionHostMsg_GetAppInstallState,