Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 17524010: Change default Omaha installsource param from "" to "ondemand" (Closed)

Created:
7 years, 6 months ago by asargent_no_longer_on_chrome
Modified:
7 years, 6 months ago
Reviewers:
waffles, Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Change default Omaha installsource param from "" to "ondemand" This will let Omaha know the difference between new, on-demand installs that are manually initiated from the webstore, and the background autoupdate checks that we do for already installed extensions/apps. BUG=249187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
asargent_no_longer_on_chrome
waffles: please review from Omaha's perspective
7 years, 6 months ago (2013-06-21 21:57:12 UTC) #1
waffles
lgtm
7 years, 6 months ago (2013-06-21 22:01:02 UTC) #2
asargent_no_longer_on_chrome
Matt: please rubberstamp
7 years, 6 months ago (2013-06-21 22:04:06 UTC) #3
Matt Perry
lgtm
7 years, 6 months ago (2013-06-21 22:05:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/17524010/1
7 years, 6 months ago (2013-06-21 22:07:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/17524010/1
7 years, 6 months ago (2013-06-22 02:45:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/17524010/1
7 years, 6 months ago (2013-06-22 03:08:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/17524010/1
7 years, 6 months ago (2013-06-22 03:21:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/17524010/1
7 years, 6 months ago (2013-06-22 03:36:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/17524010/1
7 years, 6 months ago (2013-06-22 03:43:53 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 14:53:23 UTC) #11
Message was sent while issue was closed.
Change committed as 208048

Powered by Google App Engine
This is Rietveld 408576698