Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 17524003: Fix ProfileForPath in ExtensionAppShimHandler. (Closed)

Created:
7 years, 6 months ago by jackhou1
Modified:
7 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix ProfileForPath in ExtensionAppShimHandler. Broke this in http://crrev.com/17366002 ProfileManager::GetProfile() takes the full path to the profile, not the base name. BUG=168080 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M apps/app_shim/extension_app_shim_handler_mac.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jackhou1
7 years, 6 months ago (2013-06-21 01:34:39 UTC) #1
tapted
lgtm
7 years, 6 months ago (2013-06-21 01:38:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/17524003/1
7 years, 6 months ago (2013-06-21 01:42:57 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 06:23:51 UTC) #4
Message was sent while issue was closed.
Change committed as 207733

Powered by Google App Engine
This is Rietveld 408576698