Issue 17523002: InstantExtended: Don't create overlay, again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17523002: InstantExtended: Don't create overlay, again. (Closed)

Created:
7 years, 6 months ago by Jered

Modified:
7 years, 6 months ago

Reviewers:

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

InstantExtended: Don't create overlay, again. Also, re-enable 25 of our tests that were randomly commented out. Several don't work anymore. BUG=247717 TEST=Yes. TBR=samarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207790

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -1771 lines)			Patch
M	chrome/browser/ui/search/instant_controller.h	View	2 chunks	+3 lines, -37 lines	0 comments	Download
M	chrome/browser/ui/search/instant_controller.cc	View	10 chunks	+15 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View	40 chunks	+138 lines, -1655 lines	0 comments	Download
M	chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc	View	3 chunks	+13 lines, -44 lines	0 comments	Download
M	chrome/browser/ui/search/instant_test_utils.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/search/instant_test_utils.cc	View	1 chunk	+1 line, -15 lines	0 comments	Download
M	chrome/browser/ui/search/local_ntp_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/17523002/1

7 years, 6 months ago (2013-06-21 00:15:14 UTC) #1

Message was sent while issue was closed.

Change committed as 207790

Expand Messages | Collapse Messages