Issue 17521002: Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding mos…

Issue 17521002: Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding mos… (Closed)

Created:
7 years, 6 months ago by kmadhusu

Modified:
7 years, 6 months ago

Reviewers:
samarth

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding most visited items. SearchTabHelper no longer tracks the last known most visited items list. BUG=248683 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208086

Patch Set 1 : '' #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Addressed comments #

Total comments: 2

Patch Set 5 : Addressed comment. #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -61 lines)			Patch
M	chrome/browser/search/instant_service.cc	View	1 2 3 4 5	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/search/search.h	View	1 2	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/search/search.cc	View	1 2	1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/search/instant_controller.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.h	View	1 2 3 4 5	3 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View	1 2 3 4 5	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox.cc	View	1 2 3 4 5	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

samarth

https://codereview.chromium.org/17521002/diff/10001/chrome/renderer/searchbox/searchbox.cc File chrome/renderer/searchbox/searchbox.cc (right): https://codereview.chromium.org/17521002/diff/10001/chrome/renderer/searchbox/searchbox.cc#newcode520 chrome/renderer/searchbox/searchbox.cc:520: for (std::vector<InstantMostVisitedItemIDPair>::const_iterator it = Why bother converting the list? ...

7 years, 6 months ago (2013-06-21 20:51:19 UTC) #2

kmadhusu

7 years, 6 months ago (2013-06-21 21:35:31 UTC) #3

samarth

lgtm https://codereview.chromium.org/17521002/diff/18001/chrome/renderer/searchbox/searchbox.cc File chrome/renderer/searchbox/searchbox.cc (right): https://codereview.chromium.org/17521002/diff/18001/chrome/renderer/searchbox/searchbox.cc#newcode34 chrome/renderer/searchbox/searchbox.cc:34: std::vector<InstantMostVisitedItemIDPair> old_item_id_pairs, const reference, please

7 years, 6 months ago (2013-06-21 22:03:42 UTC) #4

kmadhusu

Thanks. https://codereview.chromium.org/17521002/diff/18001/chrome/renderer/searchbox/searchbox.cc File chrome/renderer/searchbox/searchbox.cc (right): https://codereview.chromium.org/17521002/diff/18001/chrome/renderer/searchbox/searchbox.cc#newcode34 chrome/renderer/searchbox/searchbox.cc:34: std::vector<InstantMostVisitedItemIDPair> old_item_id_pairs, On 2013/06/21 22:03:43, samarth wrote: > ...

7 years, 6 months ago (2013-06-21 22:07:09 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17521002/36001

7 years, 6 months ago (2013-06-22 18:29:01 UTC) #6

Message was sent while issue was closed.

Change committed as 208086

Expand Messages | Collapse Messages