Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 17520005: drive: Pass TaskRunner to DriveUploader explicitly (Closed)

Created:
7 years, 6 months ago by hashimoto
Modified:
7 years, 6 months ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Pass TaskRunner to DriveUploader explicitly BUG=252588 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207852

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -70 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_app_registry_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 32 chunks +35 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/drive/drive_uploader.h View 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/drive/drive_uploader.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/drive/drive_uploader_unittest.cc View 17 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/drive/api_util.cc View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
tzik@: Please review sync_file_system. kinaba@: Please review other parts.
7 years, 6 months ago (2013-06-21 09:14:07 UTC) #1
kinaba
lgtm
7 years, 6 months ago (2013-06-21 09:15:59 UTC) #2
tzik
lgtm
7 years, 6 months ago (2013-06-21 11:21:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/17520005/2001
7 years, 6 months ago (2013-06-21 12:05:02 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 16:21:31 UTC) #5
Message was sent while issue was closed.
Change committed as 207852

Powered by Google App Engine
This is Rietveld 408576698