Issue 17517005: Match the NativeTextfieldViews cursor color to the text color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17517005: Match the NativeTextfieldViews cursor color to the text color. (Closed)

Created:
7 years, 6 months ago by msw

Modified:
7 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, Peter Kasting, dmazzoni

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Match the NativeTextfieldViews cursor color to the text color. The NativeTextfieldViews cursor color is hard-coded black. Instead, set the cursor color to Textfield::GetTextColor. This supports more Windows high-contrast black themes, etc. However, if Windows has red text, they'll get red cursors. (I think accessibility trumps that questionable coloring) (also, the native behavior is worse in my ugly test theme) BUG=252385, 131660 TEST=Views Textfields cursors match their overall text color; meets accessibility requirements without other seriously negative effects. R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207795

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	ui/views/controls/textfield/native_textfield_views.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/17517005/1

7 years, 6 months ago (2013-06-20 23:28:56 UTC) #3

Message was sent while issue was closed.

Change committed as 207795

Expand Messages | Collapse Messages