Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 17517004: cros: Use custom icon for low-power charger notification (Closed)

Created:
7 years, 6 months ago by James Cook
Modified:
7 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

cros: Use custom icon for low-power charger notification Wires up an existing art asset BUG=249852 TEST=visual, it uses the new art Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M ash/resources/ash_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/chromeos/power/tray_power.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Dan, PTAL The naming of the IDR constant is weird (IDR_AURA instead of IDR_ASH) but ...
7 years, 6 months ago (2013-06-20 21:47:55 UTC) #1
Daniel Erat
lgtm
7 years, 6 months ago (2013-06-20 22:00:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/17517004/1
7 years, 6 months ago (2013-06-20 22:03:11 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 05:37:18 UTC) #4
Message was sent while issue was closed.
Change committed as 207719

Powered by Google App Engine
This is Rietveld 408576698