Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 17514009: Fix flakiness in using touch with immersive fullscreen (Closed)

Created:
7 years, 6 months ago by pkotwicz
Modified:
7 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Ignores synthetic mouse events in ImmersiveModeControllerAsh::OnMouseEvent(). Counterintuitively, we get synthetic mouse events when aura::client::CursorClient::IsMouseEventsEnabled() == false. BUG=252230 Test=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208097

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
James, PTAL
7 years, 6 months ago (2013-06-21 14:38:52 UTC) #1
James Cook
lgtm
7 years, 6 months ago (2013-06-21 18:11:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/17514009/1
7 years, 6 months ago (2013-06-22 16:44:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/17514009/15001
7 years, 6 months ago (2013-06-22 18:48:53 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 22:33:57 UTC) #5
Message was sent while issue was closed.
Change committed as 208097

Powered by Google App Engine
This is Rietveld 408576698