Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 17514007: Add a test for base::Bind() and scoped_refptrs copies. (Closed)

Created:
7 years, 6 months ago by willchan no longer on Chromium
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add a test for base::Bind() and scoped_refptrs copies. Specifically tracks the number of AddRef()/Release() pairs called for a method expecting a "const scoped_refptr<T>&". base::Bind()'s impl currently leads to too many AddRef()/Release() pairs. BUG=251937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208087

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove spurious newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M base/bind_unittest.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
willchan no longer on Chromium
Haven't written code in months so I figured it'd be a nice thing to make ...
7 years, 6 months ago (2013-06-21 03:33:15 UTC) #1
awong
LGTM I should have added this test from the beginning. Thanks for adding it now. ...
7 years, 6 months ago (2013-06-21 19:46:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/17514007/17001
7 years, 6 months ago (2013-06-21 21:38:49 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=167940
7 years, 6 months ago (2013-06-22 02:08:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/17514007/17001
7 years, 6 months ago (2013-06-22 19:34:50 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 20:32:51 UTC) #6
Message was sent while issue was closed.
Change committed as 208087

Powered by Google App Engine
This is Rietveld 408576698