Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 17513003: Chromoting Host: Don't listen for PRIMARY selection changes (Closed)

Created:
7 years, 6 months ago by Lambros
Modified:
7 years, 6 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, dcheng, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Chromoting Host: Don't listen for PRIMARY selection changes This CL makes the Chromoting host clipboard handling match what Chrome does on Linux: it listens only for CLIPBOARD changes, but sets both CLIPBOARD and PRIMARY selections. This also fixes the problem of the Linux host copying PRIMARY to CLIPBOARD: When the user mouse-selected some text, the host process would assert CLIPBOARD ownership with that selected text. This clobbered any previous CLIPBOARD data, and frustrated the user. BUG=169965 TEST=manually verify clipboard contents using "xsel" or similar. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M remoting/host/linux/x_server_clipboard.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lambros
We could remove PRIMARY handling altogether, but I think that should be a separate CL ...
7 years, 6 months ago (2013-06-20 22:51:42 UTC) #1
Wez
On 2013/06/20 22:51:42, Lambros wrote: > We could remove PRIMARY handling altogether, but I think ...
7 years, 6 months ago (2013-06-20 23:35:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/17513003/1
7 years, 6 months ago (2013-06-21 01:37:05 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 06:27:20 UTC) #4
Message was sent while issue was closed.
Change committed as 207734

Powered by Google App Engine
This is Rietveld 408576698