Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 17504004: Add test storage monitor for MediaGalleries Private API browser test. (Closed)

Created:
7 years, 6 months ago by Greg Billock
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add test storage monitor for this browser test. It looks like the test was flaky because this test slipped through the cracks. We weren't initializing the storage monitor, so there was a race where it might not be fully initialized when the test ran. Switched to using the test storage monitor as the other API browser tests do (and are not flaky). R=vandebo@chromium.org BUG=247336 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc View 2 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Greg Billock
7 years, 6 months ago (2013-06-20 21:42:14 UTC) #1
vandebo (ex-Chrome)
LGTM
7 years, 6 months ago (2013-06-20 21:48:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/17504004/1
7 years, 6 months ago (2013-06-20 22:07:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=11057
7 years, 6 months ago (2013-06-20 22:40:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/17504004/1
7 years, 6 months ago (2013-06-20 22:41:49 UTC) #5
vandebo (ex-Chrome)
+asargent for OWNERS review.
7 years, 6 months ago (2013-06-20 22:42:36 UTC) #6
asargent_no_longer_on_chrome
lgtm
7 years, 6 months ago (2013-06-20 23:39:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/17504004/1
7 years, 6 months ago (2013-06-21 14:38:19 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 17:00:38 UTC) #9
Message was sent while issue was closed.
Change committed as 207866

Powered by Google App Engine
This is Rietveld 408576698