Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 17502004: Don't issue Stop() for spurious command line differences. (Closed)

Created:
7 years, 6 months ago by DaleCurtis
Modified:
7 years, 6 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't issue Stop() for spurious command line differences. The android driver was checking self._current_cmd_line against its own _android_driver_cmd_line() even though ServerProcess.start() was setting that value based on the normal cmd_line(). Doing so results in the appearance of different command lines which causes a ServerProcess.stop() to be issued and tear everything down. Example: _android_driver_cmd_line() = ['ContentShell.apk', '--no-timeout', '--encode-binary', '--enable-hardware-gpu', '--force-compositing-mode', '--enable-accelerated-fixed-position', '--dump-render-tree', '-'] _cmd_line() = ['adb', '-s', u'04aa0e7cdd540dac', 'shell'] Now a single content_shell instance is responsible for running all the tests! Much faster :) BUG=232044 TEST=content_shell tests use a single instance. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
7 years, 6 months ago (2013-06-20 21:11:38 UTC) #1
Peter Beverloo
lgtm, thanks!
7 years, 6 months ago (2013-06-20 21:43:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/17502004/1
7 years, 6 months ago (2013-06-20 21:47:50 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=10581
7 years, 6 months ago (2013-06-21 00:18:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/17502004/1
7 years, 6 months ago (2013-06-21 00:35:59 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 01:13:19 UTC) #6
Message was sent while issue was closed.
Change committed as 152840

Powered by Google App Engine
This is Rietveld 408576698