Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5368)

Unified Diff: chrome/browser/ui/tab_modal_confirm_dialog_delegate.h

Issue 17500003: Close web contents modal dialogs on content load start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compilation fixes, change "inhibit" variable names Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_modal_confirm_dialog_delegate.h
diff --git a/chrome/browser/ui/tab_modal_confirm_dialog_delegate.h b/chrome/browser/ui/tab_modal_confirm_dialog_delegate.h
index e58e00de741d07fa327d4454c9805013b60f5830..4f20b0757a4f2634ac0c80271ed597aeb5b098f0 100644
--- a/chrome/browser/ui/tab_modal_confirm_dialog_delegate.h
+++ b/chrome/browser/ui/tab_modal_confirm_dialog_delegate.h
@@ -20,15 +20,18 @@ namespace gfx {
class Image;
}
-class TabModalConfirmDialogCloseDelegate {
+// Operations to be performed on the dialog by the
+// TabModalConfirmDialogDelegate.
+class TabModalConfirmDialogOperationsDelegate {
public:
- TabModalConfirmDialogCloseDelegate() {}
- virtual ~TabModalConfirmDialogCloseDelegate() {}
+ TabModalConfirmDialogOperationsDelegate() {}
+ virtual ~TabModalConfirmDialogOperationsDelegate() {}
virtual void CloseDialog() = 0;
+ virtual void SetPreventCloseOnLoadStart(bool prevent) = 0;
private:
- DISALLOW_COPY_AND_ASSIGN(TabModalConfirmDialogCloseDelegate);
+ DISALLOW_COPY_AND_ASSIGN(TabModalConfirmDialogOperationsDelegate);
};
// This class acts as the delegate for a simple tab-modal dialog confirming
@@ -38,8 +41,9 @@ class TabModalConfirmDialogDelegate : public content::NotificationObserver {
explicit TabModalConfirmDialogDelegate(content::WebContents* web_contents);
virtual ~TabModalConfirmDialogDelegate();
- void set_close_delegate(TabModalConfirmDialogCloseDelegate* close_delegate) {
- close_delegate_ = close_delegate;
+ void set_operations_delegate(
+ TabModalConfirmDialogOperationsDelegate* operations_delegate) {
+ operations_delegate_ = operations_delegate;
}
// Accepts the confirmation prompt and calls |OnAccepted|.
@@ -81,12 +85,12 @@ class TabModalConfirmDialogDelegate : public content::NotificationObserver {
virtual const char* GetCancelButtonIcon();
protected:
- TabModalConfirmDialogCloseDelegate* close_delegate() {
- return close_delegate_;
+ TabModalConfirmDialogOperationsDelegate* operations_delegate() {
+ return operations_delegate_;
}
// content::NotificationObserver implementation.
- // Watch for a new load or a closed tab and dismiss the dialog if they occur.
+ // Watch for a closed tab and dismiss the dialog if it occurs.
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
@@ -109,7 +113,7 @@ class TabModalConfirmDialogDelegate : public content::NotificationObserver {
// Close the dialog.
void CloseDialog();
- TabModalConfirmDialogCloseDelegate* close_delegate_;
+ TabModalConfirmDialogOperationsDelegate* operations_delegate_;
// True iff we are in the process of closing, to avoid running callbacks
// multiple times.
bool closing_;
« no previous file with comments | « chrome/browser/ui/tab_modal_confirm_dialog.h ('k') | chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698