chrome/browser/android/shortcut_helper.h - Issue 1749603002: Store URLs in WebappDataStorage, and purge them when history is cleared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 1749603002: Store URLs in WebappDataStorage, and purge them when history is cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments, renaming methods Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java ('K') | « chrome/browser/android/banners/app_banner_data_fetcher_android.cc ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_helper.h

diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h

index 02929623f548aae0bfe717ff5ee963cdb31980a4..eac2cf13876f75d05c54846ebe5164379a1f3716 100644

--- a/chrome/browser/android/shortcut_helper.h

+++ b/chrome/browser/android/shortcut_helper.h

@@ -48,10 +48,12 @@ class ShortcutHelper {

const GURL& image_url,

const int ideal_splash_image_size_in_dp,

const int minimum_splash_image_size_in_dp,

- const std::string& webapp_id);

+ const std::string& webapp_id,

+ const std::string& webapp_url);

// Stores the data of the webapp which is not placed inside the shortcut.

static void StoreWebappData(const std::string& webapp_id,

+ const std::string& webapp_url,

const SkBitmap& splash_image);

// Modify the given icon to matche the launcher requirements, then returns the