chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java - Issue 1749603002: Store URLs in WebappDataStorage, and purge them when history is cleared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java

Issue 1749603002: Store URLs in WebappDataStorage, and purge them when history is cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java » ('j') | chrome/browser/android/webapps/webapp_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java

index 5cbce869b3b65db1587c5895c34658ebc164cfa4..f5daf1afef973d817935073c830f5f7567515b93 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java

@@ -28,6 +28,7 @@ public abstract class WebappActivityTestBase extends ChromeActivityTestCaseBase<

static final String WEBAPP_ID = "webapp_id";

static final String WEBAPP_NAME = "webapp name";

static final String WEBAPP_SHORT_NAME = "webapp short name";

+ static final String WEBAPP_URL = "https://www.google.com";

// Empty 192x192 image generated with:

// ShortcutHelper.encodeBitmapAsString(Bitmap.createBitmap(192, 192, Bitmap.Config.ARGB_4444));

@@ -91,7 +92,8 @@ public abstract class WebappActivityTestBase extends ChromeActivityTestCaseBase<

// Register the webapp so when the data storage is opened, the test doesn't crash. There is

// no race condition with the retrival as AsyncTasks are run sequentially on the background

// thread.

- WebappRegistry.registerWebapp(getInstrumentation().getTargetContext(), WEBAPP_ID);

+ WebappRegistry.registerWebapp(getInstrumentation().getTargetContext(),

+ WEBAPP_ID, WEBAPP_URL);

}

/**