Add a private API method metricsPrivate.getFieldTrial(), which returns

Add a private API method metricsPrivate.getFieldTrial(), which returns
the group for field trial experiment. Equivalent to
FieldTrialList::FindFullName().

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208101

[Jeffrey Yasskin, 2013-06-21 21:55:43]

lgtm. cc'ing other people who've been involved with the metricsPrivate API as an
FYI.

[Matt Perry, 2013-06-21 22:00:19]

https://codereview.chromium.org/17496005/diff/3001/chrome/common/extensions/a...
File chrome/common/extensions/api/metrics_private.json (right):

https://codereview.chromium.org/17496005/diff/3001/chrome/common/extensions/a...
chrome/common/extensions/api/metrics_private.json:45: "description": "Returns
the group name chosen for the named trial, or the empty string if the trial does
not exist.",
nit: it's unclear to me whether "field trial exists" means that the field trial
is enabled in this client, or just that the field trial is a valid trial name.
could you clarify in the description?

[vadimt1, 2013-06-21 22:17:21]

Yey!
This gives me real peace of mind (and I won't have to do this myself :) )!


On Fri, Jun 21, 2013 at 3:00 PM, <mpcomplete@chromium.org> wrote:

>
> https://codereview.chromium.**org/17496005/diff/3001/chrome/**
>
common/extensions/api/metrics_**private.json<https://codereview.chromium.org/17496005/diff/3001/chrome/common/extensions/api/metrics_private.json>
> File chrome/common/extensions/api/**metrics_private.json (right):
>
> https://codereview.chromium.**org/17496005/diff/3001/chrome/**
>
common/extensions/api/metrics_**private.json#newcode45<https://codereview.chromium.org/17496005/diff/3001/chrome/common/extensions/api/metrics_private.json#newcode45>
> chrome/common/extensions/api/**metrics_private.json:45: "description":
> "Returns the group name chosen for the named trial, or the empty string
> if the trial does not exist.",
> nit: it's unclear to me whether "field trial exists" means that the
> field trial is enabled in this client, or just that the field trial is a
> valid trial name. could you clarify in the description?
>
>
https://codereview.chromium.**org/17496005/<https://codereview.chromium.org/1...
>



-- 
Thank you!
Vadim

[Oleg Eterevsky, 2013-06-22 19:53:08]

https://codereview.chromium.org/17496005/diff/3001/chrome/common/extensions/a...
File chrome/common/extensions/api/metrics_private.json (right):

https://codereview.chromium.org/17496005/diff/3001/chrome/common/extensions/a...
chrome/common/extensions/api/metrics_private.json:45: "description": "Returns
the group name chosen for the named trial, or the empty string if the trial does
not exist.",
On 2013/06/21 22:00:19, Matt Perry wrote:
> nit: it's unclear to me whether "field trial exists" means that the field
trial
> is enabled in this client, or just that the field trial is a valid trial name.
> could you clarify in the description?

Added "or is not enabled".

[commit-bot: I haz the power, 2013-06-22 19:53:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oleg@chromium.org/17496005/13001

[commit-bot: I haz the power, 2013-06-22 23:01:47]

Change committed as 208101