Issue 17496004: Do not consider title from non-css stylesheet for preferred set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17496004: Do not consider title from non-css stylesheet for preferred set. (Closed)

Created:
7 years, 6 months ago by rune

Modified:
7 years, 6 months ago

Reviewers:
dglazkov

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Do not consider title from non-css stylesheet for preferred set. Title on a style element can be used to select the preferred stylesheet set. If the type attribute of the style element is not text/css, the title should never be set as the key for the preferred stylesheet set. BUG=252215 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152797

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -4 lines)			Patch
A	LayoutTests/fast/css/style-preferred-stylesheet-01.html	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/css/style-preferred-stylesheet-01-expected.html	View	1 chunk	+1 line, -4 lines	0 comments	Download
A	LayoutTests/fast/css/style-preferred-stylesheet-02.html	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/css/style-preferred-stylesheet-02-expected.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/17496004/1

7 years, 6 months ago (2013-06-20 15:45:45 UTC) #3

Message was sent while issue was closed.

Change committed as 152797

Expand Messages | Collapse Messages