Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Issue 17494004: Update Managed user strings for ChromeOS (Closed)

Created:
7 years, 6 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update frew more strings #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -94 lines) Patch
M ash/system/tray/system_tray_delegate.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/tray/test_system_tray_delegate.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/tray/test_system_tray_delegate.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +88 lines, -80 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Denis Kuznetsov (DE-MUC)
go/playpen-m29-strings
7 years, 6 months ago (2013-06-20 15:34:32 UTC) #1
ygorshenin1
https://chromiumcodereview.appspot.com/17494004/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://chromiumcodereview.appspot.com/17494004/diff/1/chrome/app/chromeos_strings.grdp#newcode469 chrome/app/chromeos_strings.grdp:469: <ph name="LINK_START">$1<ex>&gt;a&lt;</ex></ph>Create a supervised users<ph name="LINK_END">$2<ex>&gt;/a&lt;</ex></ph> for this device. ...
7 years, 6 months ago (2013-06-20 15:48:35 UTC) #2
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/17494004/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/17494004/diff/1/chrome/app/chromeos_strings.grdp#newcode469 chrome/app/chromeos_strings.grdp:469: <ph name="LINK_START">$1<ex>&gt;a&lt;</ex></ph>Create a supervised users<ph name="LINK_END">$2<ex>&gt;/a&lt;</ex></ph> for this device. ...
7 years, 6 months ago (2013-06-20 16:22:36 UTC) #3
ygorshenin1
lgtm
7 years, 6 months ago (2013-06-20 18:02:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/17494004/6001
7 years, 6 months ago (2013-06-20 18:48:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=10967
7 years, 6 months ago (2013-06-20 18:59:25 UTC) #6
Denis Kuznetsov (DE-MUC)
7 years, 6 months ago (2013-06-20 20:18:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/17494004/6001
7 years, 6 months ago (2013-06-20 20:19:28 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=52587
7 years, 6 months ago (2013-06-20 22:13:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/17494004/34001
7 years, 6 months ago (2013-06-21 12:25:09 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 16:19:23 UTC) #11
Message was sent while issue was closed.
Change committed as 207849

Powered by Google App Engine
This is Rietveld 408576698