Issue 17484004: android: Always initialize 'log' variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17484004: android: Always initialize 'log' variable (Closed)

Created:
7 years, 6 months ago by Sami

Modified:
7 years, 6 months ago

Reviewers:
bulach

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android: Always initialize 'log' variable Always initialize the 'log' variable to avoid an unbound local error when dealing with exceptions. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207648

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/android/pylib/gtest/test_package.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sami

This will fix errors like the one here: http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28JB%20Nexus7%29%28dbg%29/builds/10705/steps/content_browsertests/logs/stdio

7 years, 6 months ago (2013-06-20 10:16:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/17484004/1

7 years, 6 months ago (2013-06-20 12:10:49 UTC) #3

Message was sent while issue was closed.

Change committed as 207648

Expand Messages | Collapse Messages