Issue 17472002: Use new logos in requestAutocomplete splash page.

Issue 17472002: Use new logos in requestAutocomplete splash page. (Closed)

Created:
7 years, 6 months ago by Evan Stade

Modified:
7 years, 6 months ago

Reviewers:
Dmitry Polukhin, sail, Dan Beam

CC:
chromium-reviews, Raman Kakilate, oshima+watch_chromium.org, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org, Dmitry Zvorygin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use new logos in requestAutocomplete splash page. BUG=243555 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207787

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/app/theme/theme_resources.grd	View		2 chunks	+2 lines, -0 lines	1 comment	Download
	M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/17472002/1

7 years, 6 months ago (2013-06-20 18:08:21 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=10950

7 years, 6 months ago (2013-06-20 18:19:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/17472002/1

7 years, 6 months ago (2013-06-20 22:39:12 UTC) #7

Dmitry Polukhin

7 years, 6 months ago (2013-06-21 12:54:03 UTC) #9

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/17472002/diff/1/chrome/app/theme/theme...
File chrome/app/theme/theme_resources.grd (right):

https://chromiumcodereview.appspot.com/17472002/diff/1/chrome/app/theme/theme...
chrome/app/theme/theme_resources.grd:633: <structure type="chrome_scaled_image"
name="IDR_PRODUCT_LOGO_NAME_48" file="google_chrome/product_logo_name_48.png" />
This CL broke official builds, see
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/...

Expand Messages | Collapse Messages