LayoutTests/fast/events/touch/touch-hit-rects-in-iframe.html - Issue 17471008: Rework compositor touch hit testing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/touch-hit-rects-in-iframe.html

Issue 17471008: Rework compositor touch hit testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: CR feedback - accumulate LayoutRects instead of IntRects, disable when page isn't composited. Also… Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/events/touch/resources/frame-with-touch-handler.html ('k') | LayoutTests/fast/events/touch/touch-hit-rects-in-iframe-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <html>

3 <head>

4 <style>

5 #iframe1 {

6 position: absolute;

7 top: 100px;

8 left: 50px;

9 width: 200px;

10 height: 200px;

11 }

12 #iframe2 {

13 position: absolute;

14 top: 100px;

15 left: 400px;

16 width: 200px;

17 height: 200px;

18 }

19 </style>

20 <body onload="runTest();">

21 <div>This test validates that touch hit tests rects are created in the coordinat es of the outermost view, not their containing view.

22 This test only works in DumpRenderTree.</div>

23 <div id="console"></div>

24 <iframe id="iframe1" src="resources/frame-with-touch-handler.html"></iframe>

25 <iframe id="iframe2"></iframe>

26 <iframe id="iframe3" src="resources/frame-with-document-touch-handler.html"></if rame>

27 <script>

28

29 var iframeDocument = document.getElementById("iframe2").contentWindow.document;

30 iframeDocument.open('text/html', 'replace');

31 iframeDocument.write("<!DOCTYPE html>\n<html><body><iframe src=\"resources/frame -with-touch-handler.html\" style=\"position: relative; top: 50px;\"></iframe></b ody>");

32 iframeDocument.close();

33

34 function log(msg) {

35 var span = document.createElement("span");

36 document.getElementById("console").appendChild(span);

37 span.innerHTML = msg + '<br />';

38 }

39

40 function sortRects(a, b) {

41 return a.top - b.top;

42 }

43

44 function runTest() {

45 if (!window.testRunner)

46 return;

47 window.testRunner.dumpAsText();

48

49 rects = window.internals.touchEventTargetClientRects(document);

50 var sortedRects = new Array();

51 for (var i = 0; i < rects.length; ++i)

52 sortedRects[i] = rects[i];

53 sortedRects.sort(sortRects);

54 for (var i = 0; i < rects.length; ++i)

55 log("[" + i + "]: (" + sortedRects[i].left + ", " + sortedRects[ i].top + ", " + sortedRects[i].width + ", " + sortedRects[i].height + ")");

56 }

57 </script>

58 </body>

OLD	NEW