chrome://identity-internals code quality

* Updating the code comments
* Renaming tokend ID to access token (including the id of the resource).
* Updating Token Id => Access Token in the resource file.

BUG=243143
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207860

[fgorski, 2013-06-19 23:56:26]

Please take a look:
* arv@: chrome/browser/*
* cpu@: chrome/app/generated_resources.grd

* courage@: all

Thanks.
Filip

[Michael Courage, 2013-06-20 09:40:54]

lgtm with a few nits. Ok, half a dozen, but since this is a nit cleanup CL... :)

https://codereview.chromium.org/17468008/diff/6/chrome/browser/resources/iden...
File chrome/browser/resources/identity_internals.js (right):

https://codereview.chromium.org/17468008/diff/6/chrome/browser/resources/iden...
chrome/browser/resources/identity_internals.js:201: * an access token, of the
token to be removed.
This is slightly awkward phrasing after the rename. Maybe "which is the access
token to be removed"

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
File chrome/browser/ui/webui/identity_internals_ui.cc (right):

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui.cc:58: // Gets a name of an
extension referred to by |token_cache_key| as a string.
tinynit: s/Gets a/Gets the/

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui.cc:79: // readible form and
returns a pointer to created object. Caller gets the
nits:
s/readible/readable/
returns a pointer to _the_ created object

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui.cc:85: // Gets all of the tokens
stored in IdenityAPI token cache and returns them
s/IdenityAPI/IdentityAPI/

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
File chrome/browser/ui/webui/identity_internals_ui_browsertest.js (right):

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui_browsertest.js:247:
tokenRevokeDone.call(identity_internals, tokenIds);
s/tokenIds/accessTokens/

[arv (Not doing code reviews), 2013-06-20 14:06:40]

LGTM with the nits fixed

https://codereview.chromium.org/17468008/diff/6/chrome/browser/resources/iden...
File chrome/browser/resources/identity_internals.js (right):

https://codereview.chromium.org/17468008/diff/6/chrome/browser/resources/iden...
chrome/browser/resources/identity_internals.js:201: * an access token, of the
token to be removed.
On 2013/06/20 09:40:54, Michael Courage wrote:
> This is slightly awkward phrasing after the rename. Maybe "which is the access
> token to be removed"

Yeah, that would read better.

[commit-bot: I haz the power, 2013-06-20 16:28:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fgorski@chromium.org/17468008/8001

[fgorski, 2013-06-20 16:28:48]

thanks for the review. I addressed the nits and submitted to the CQ.

https://codereview.chromium.org/17468008/diff/6/chrome/browser/resources/iden...
File chrome/browser/resources/identity_internals.js (right):

https://codereview.chromium.org/17468008/diff/6/chrome/browser/resources/iden...
chrome/browser/resources/identity_internals.js:201: * an access token, of the
token to be removed.
On 2013/06/20 14:06:40, arv wrote:
> On 2013/06/20 09:40:54, Michael Courage wrote:
> > This is slightly awkward phrasing after the rename. Maybe "which is the
access
> > token to be removed"
> 
> Yeah, that would read better.

Done. And yes... a little embarrassed.

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
File chrome/browser/ui/webui/identity_internals_ui.cc (right):

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui.cc:58: // Gets a name of an
extension referred to by |token_cache_key| as a string.
On 2013/06/20 09:40:54, Michael Courage wrote:
> tinynit: s/Gets a/Gets the/

Done.

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui.cc:79: // readible form and
returns a pointer to created object. Caller gets the
On 2013/06/20 09:40:54, Michael Courage wrote:
> nits:
> s/readible/readable/
> returns a pointer to _the_ created object

Done.

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui.cc:85: // Gets all of the tokens
stored in IdenityAPI token cache and returns them
On 2013/06/20 09:40:54, Michael Courage wrote:
> s/IdenityAPI/IdentityAPI/

Done.

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
File chrome/browser/ui/webui/identity_internals_ui_browsertest.js (right):

https://codereview.chromium.org/17468008/diff/6/chrome/browser/ui/webui/ident...
chrome/browser/ui/webui/identity_internals_ui_browsertest.js:247:
tokenRevokeDone.call(identity_internals, tokenIds);
On 2013/06/20 09:40:54, Michael Courage wrote:
> s/tokenIds/accessTokens/

Done. And nice catch.

[cpu_(ooo_6.6-7.5), 2013-06-20 22:44:41]

grd changes can be TBRd

[commit-bot: I haz the power, 2013-06-21 16:04:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fgorski@chromium.org/17468008/8001

[commit-bot: I haz the power, 2013-06-21 16:42:00]

Change committed as 207860