| Index: content/common/gpu/media/android_video_decode_accelerator.cc
|
| diff --git a/content/common/gpu/media/android_video_decode_accelerator.cc b/content/common/gpu/media/android_video_decode_accelerator.cc
|
| index 3942a80ff3b4b27e042912b7853cfaac8cdc1702..5c1a90c6f9a3fef8b44723ce10bdec677b6a9210 100644
|
| --- a/content/common/gpu/media/android_video_decode_accelerator.cc
|
| +++ b/content/common/gpu/media/android_video_decode_accelerator.cc
|
| @@ -239,32 +239,21 @@ static base::LazyInstance<AVDATimerManager>::Leaky g_avda_timer =
|
| LAZY_INSTANCE_INITIALIZER;
|
|
|
| AndroidVideoDecodeAccelerator::AndroidVideoDecodeAccelerator(
|
| - const base::WeakPtr<gpu::gles2::GLES2Decoder> decoder,
|
| - const base::Callback<bool(void)>& make_context_current)
|
| + const gpu_vda_helpers::MakeGLContextCurrentCb& make_context_current_cb,
|
| + const gpu_vda_helpers::GetGLES2DecoderCb& get_gles2_decoder_cb)
|
| : client_(NULL),
|
| - make_context_current_(make_context_current),
|
| + make_context_current_cb_(make_context_current_cb),
|
| + get_gles2_decoder_cb_(get_gles2_decoder_cb),
|
| codec_(media::kCodecH264),
|
| is_encrypted_(false),
|
| needs_protected_surface_(false),
|
| state_(NO_ERROR),
|
| picturebuffers_requested_(false),
|
| - gl_decoder_(decoder),
|
| cdm_registration_id_(0),
|
| pending_input_buf_index_(-1),
|
| error_sequence_token_(0),
|
| defer_errors_(false),
|
| - weak_this_factory_(this) {
|
| - if (UseDeferredRenderingStrategy()) {
|
| - // TODO(liberato, watk): Figure out what we want to do about zero copy for
|
| - // fullscreen external SurfaceView in WebView. http://crbug.com/582170.
|
| - DCHECK(!gl_decoder_->GetContextGroup()->mailbox_manager()->UsesSync());
|
| - DVLOG(1) << __FUNCTION__ << ", using deferred rendering strategy.";
|
| - strategy_.reset(new AndroidDeferredRenderingBackingStrategy(this));
|
| - } else {
|
| - DVLOG(1) << __FUNCTION__ << ", using copy back strategy.";
|
| - strategy_.reset(new AndroidCopyingBackingStrategy(this));
|
| - }
|
| -}
|
| + weak_this_factory_(this) {}
|
|
|
| AndroidVideoDecodeAccelerator::~AndroidVideoDecodeAccelerator() {
|
| DCHECK(thread_checker_.CalledOnValidThread());
|
| @@ -287,6 +276,11 @@ bool AndroidVideoDecodeAccelerator::Initialize(const Config& config,
|
|
|
| DVLOG(1) << __FUNCTION__ << ": " << config.AsHumanReadableString();
|
|
|
| + if (make_context_current_cb_.is_null() || get_gles2_decoder_cb_.is_null()) {
|
| + NOTREACHED() << "GL callbacks are required for this VDA";
|
| + return false;
|
| + }
|
| +
|
| DCHECK(client);
|
| client_ = client;
|
| codec_ = VideoCodecProfileToVideoCodec(config.profile);
|
| @@ -314,13 +308,24 @@ bool AndroidVideoDecodeAccelerator::Initialize(const Config& config,
|
| }
|
| }
|
|
|
| - if (!make_context_current_.Run()) {
|
| - LOG(ERROR) << "Failed to make this decoder's GL context current.";
|
| - return false;
|
| + if (UseDeferredRenderingStrategy()) {
|
| + // TODO(liberato, watk): Figure out what we want to do about zero copy for
|
| + // fullscreen external SurfaceView in WebView. http://crbug.com/582170.
|
| + auto gles_decoder = get_gles2_decoder_cb_.Run();
|
| + if (!gles_decoder) {
|
| + LOG(ERROR) << "Failed to get gles2 decoder instance.";
|
| + return false;
|
| + }
|
| + DCHECK(!gles_decoder->GetContextGroup()->mailbox_manager()->UsesSync());
|
| + DVLOG(1) << __FUNCTION__ << ", using deferred rendering strategy.";
|
| + strategy_.reset(new AndroidDeferredRenderingBackingStrategy(this));
|
| + } else {
|
| + DVLOG(1) << __FUNCTION__ << ", using copy back strategy.";
|
| + strategy_.reset(new AndroidCopyingBackingStrategy(this));
|
| }
|
|
|
| - if (!gl_decoder_) {
|
| - LOG(ERROR) << "Failed to get gles2 decoder instance.";
|
| + if (!make_context_current_cb_.Run()) {
|
| + LOG(ERROR) << "Failed to make this decoder's GL context current.";
|
| return false;
|
| }
|
|
|
| @@ -697,7 +702,7 @@ void AndroidVideoDecodeAccelerator::SendDecodedFrameToClient(
|
| DCHECK(!free_picture_ids_.empty());
|
| TRACE_EVENT0("media", "AVDA::SendDecodedFrameToClient");
|
|
|
| - if (!make_context_current_.Run()) {
|
| + if (!make_context_current_cb_.Run()) {
|
| POST_ERROR(PLATFORM_FAILURE, "Failed to make the GL context current.");
|
| return;
|
| }
|
| @@ -960,7 +965,7 @@ void AndroidVideoDecodeAccelerator::Reset() {
|
| void AndroidVideoDecodeAccelerator::Destroy() {
|
| DCHECK(thread_checker_.CalledOnValidThread());
|
|
|
| - bool have_context = make_context_current_.Run();
|
| + bool have_context = make_context_current_cb_.Run();
|
| if (!have_context)
|
| LOG(WARNING) << "Failed make GL context current for Destroy, continuing.";
|
|
|
| @@ -980,7 +985,9 @@ void AndroidVideoDecodeAccelerator::Destroy() {
|
| delete this;
|
| }
|
|
|
| -bool AndroidVideoDecodeAccelerator::CanDecodeOnIOThread() {
|
| +bool AndroidVideoDecodeAccelerator::TryInitializeDecodeOnSeparateThread(
|
| + const base::WeakPtr<Client>& decode_client,
|
| + const scoped_refptr<base::SingleThreadTaskRunner>& decode_task_runner) {
|
| return false;
|
| }
|
|
|
| @@ -995,7 +1002,7 @@ const base::ThreadChecker& AndroidVideoDecodeAccelerator::ThreadChecker()
|
|
|
| base::WeakPtr<gpu::gles2::GLES2Decoder>
|
| AndroidVideoDecodeAccelerator::GetGlDecoder() const {
|
| - return gl_decoder_;
|
| + return get_gles2_decoder_cb_.Run();
|
| }
|
|
|
| void AndroidVideoDecodeAccelerator::OnFrameAvailable() {
|
|
|