Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 17459003: Allow suppressed EME canPlayType() responses to be overridden with a flag. (Closed)

Created:
7 years, 6 months ago by ddorwin
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Allow suppressed EME canPlayType() responses to be overridden with a flag. Adds --override-encrypted-media-canplaytype and the corresponding flag. BUG=252967 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208096

Patch Set 1 #

Patch Set 2 : Fix compile. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/renderer/media/crypto/key_systems.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/renderer/media/crypto/key_systems_info.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/renderer/media/crypto/key_systems_info.cc View 8 chunks +25 lines, -8 lines 0 comments Download
M webkit/renderer/media/crypto/key_systems_unittest.cc View 2 chunks +11 lines, -0 lines 3 comments Download

Messages

Total messages: 12 (0 generated)
ddorwin
xhwang, PTAL. thestig, please OWNERS review content/browser/renderer_host/render_process_host_impl.cc
7 years, 6 months ago (2013-06-22 03:14:16 UTC) #1
ddorwin
https://codereview.chromium.org/17459003/diff/3001/webkit/renderer/media/crypto/key_systems_unittest.cc File webkit/renderer/media/crypto/key_systems_unittest.cc (right): https://codereview.chromium.org/17459003/diff/3001/webkit/renderer/media/crypto/key_systems_unittest.cc#newcode543 webkit/renderer/media/crypto/key_systems_unittest.cc:543: #if defined(WIDEVINE_CDM_AVAILABLE) && \ This test was actually failing ...
7 years, 6 months ago (2013-06-22 04:44:35 UTC) #2
xhwang
lgtm
7 years, 6 months ago (2013-06-22 06:32:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/17459003/3001
7 years, 6 months ago (2013-06-22 16:13:22 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=11645
7 years, 6 months ago (2013-06-22 16:22:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/17459003/3001
7 years, 6 months ago (2013-06-22 16:24:48 UTC) #6
Lei Zhang
lgtm, but I'm not a content/ OWNER.
7 years, 6 months ago (2013-06-22 17:34:26 UTC) #7
ddorwin
jochen, please OWNERS review content/browser/renderer_host/render_process_host_impl.cc On 2013/06/22 17:34:26, Lei Zhang wrote: > lgtm, but I'm ...
7 years, 6 months ago (2013-06-22 19:35:50 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 6 months ago (2013-06-22 20:07:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/17459003/3001
7 years, 6 months ago (2013-06-22 22:25:38 UTC) #10
commit-bot: I haz the power
Change committed as 208096
7 years, 6 months ago (2013-06-22 22:33:33 UTC) #11
jochen (gone - plz use gerrit)
7 years, 6 months ago (2013-06-24 09:58:30 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698