service/datastore/query.go - Issue 1745703002: Auto-project on distinct inequality fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/query.go

Issue 1745703002: Auto-project on distinct inequality fields. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Do it in finalize, not after. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: service/datastore/query.go

diff --git a/service/datastore/query.go b/service/datastore/query.go

index fc30f5f686808fc6f697a000c6be3bdf94e0cf65..8b9bf42bfa7148c6f208eed12e442f9a17150e23 100644

--- a/service/datastore/query.go

+++ b/service/datastore/query.go

@@ -575,6 +575,12 @@ func (q *Query) Finalize() (*FinalizedQuery, error) {

ret.distinct = q.distinct && q.project.Len() > 0

}

+ // If we're DISTINCT && have an inequality filter, we must project that

+ // inequality property as well.

+ if ret.distinct && ret.ineqFiltProp != "" && !q.project.Has(ret.ineqFiltProp) {

+ ret.project = append([]string{ret.ineqFiltProp}, ret.project...)

+ }

iannucci 2016/02/27 01:04:26 ah... yeah it technically works here too, I was th

seenOrders := stringset.New(len(q.order))

// if len(q.order) > 0, we already enforce that the first order

« no previous file with comments | « impl/prod/everything_test.go ('k') | service/datastore/query_test.go » ('j') | service/datastore/query_test.go » ('J')