service/datastore/query_test.go - Issue 1745703002: Auto-project on distinct inequality fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/query_test.go

Issue 1745703002: Auto-project on distinct inequality fields. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: service/datastore/query_test.go

diff --git a/service/datastore/query_test.go b/service/datastore/query_test.go

index 6c2d483c5f9fafb124a7675a72eea01baf967a88..b350b9647caa92480179df624031bcce9e7d854c 100644

--- a/service/datastore/query_test.go

+++ b/service/datastore/query_test.go

@@ -145,6 +145,11 @@ var queryTests = []queryTest{

"SELECT DISTINCT `hello` FROM `Foo` ORDER BY `hello`, `__key__`",

nil, nil},

+ {"projecting in an inequality query",

+ nq().Gte("foo", 10).Project("bar").Distinct(true),

+ "SELECT DISTINCT `bar` FROM `Foo` WHERE `foo` >= 10 ORDER BY `foo`, `bar`, `__key__`",

iannucci 2016/02/27 01:02:02 this is wrong though, it should DISTINCT `foo`, `b

+ nil, nil},

{"bad ancestors",

nq().Ancestor(mkKey("goop", 0)),

"",

« service/datastore/finalized_query.go ('K') | « service/datastore/finalized_query.go ('k') | no next file » | no next file with comments »